-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDS: add Method RevokeCertificate to Client and Server #2497
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2497 +/- ##
==========================================
- Coverage 53.97% 53.96% -0.01%
==========================================
Files 335 335
Lines 64558 64589 +31
Branches 13273 13281 +8
==========================================
+ Hits 34842 34858 +16
- Misses 25955 25958 +3
- Partials 3761 3773 +12 ☔ View full report in Codecov by Sentry. |
improve execution time handle all cases where revocation fails improve test
#2338 will change the authorization, changes needed on the PR merged last. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit, looks good
Proposed changes
Implement the method RefokeCertificate from Spec: [7.9.6 RevokeCertificate (https://reference.opcfoundation.org/GDS/v105/docs/7.9.6)]
Related Issues
Types of changes
Checklist
Further comments